Issue 20303003: Matrix decomposition cleanup: Add is_degenerate_2x2(), and fix some asserts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20303003: Matrix decomposition cleanup: Add is_degenerate_2x2(), and fix some asserts (Closed)

Created:
7 years, 5 months ago by jvanverth1

Modified:
7 years, 4 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Matrix decomposition cleanup: Add is_degenerate_2x2(), and fix some asserts (atan2 can take a zero x value, but both x == 0 and y == 0 is undefined). Committed: http://code.google.com/p/skia/source/detail?r=10410

Patch Set 1 #

Patch Set 2 : Normalize some line endings #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
	M	src/core/SkMatrix.cpp	View	1	5 chunks	+21 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/20303003/3001

7 years, 4 months ago (2013-07-29 14:36:22 UTC) #4

Message was sent while issue was closed.

Change committed as 10410

Expand Messages | Collapse Messages