Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 20246002: Rename ExperimentalShadowDOM runtime feature to ShadowDOM. (Closed)

Created:
7 years, 5 months ago by Yuta Kitamura
Modified:
7 years, 5 months ago
Reviewers:
hayato
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename ExperimentalShadowDOM runtime feature to ShadowDOM. Now all of unprefixed Shadow DOM APIs are controlled under this feature, thus it is a bit odd to call this feature Experimental. This change also removes portions of InternalSettings related to the feature. Apparently these codes are not used from anywhere. BUG=242153 R=hayato@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M Source/core/dom/Element.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Event.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventRetargeter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yuta Kitamura
7 years, 5 months ago (2013-07-25 03:35:00 UTC) #1
hayato
Looks like a mechanical change. LGTM.
7 years, 5 months ago (2013-07-25 05:00:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/20246002/1
7 years, 5 months ago (2013-07-25 05:02:22 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-25 06:32:14 UTC) #4
Message was sent while issue was closed.
Change committed as 154900

Powered by Google App Engine
This is Rietveld 408576698