Fix crash when reloading packaged app.

Fix crash when reloading packaged app. 

When a shell window was closed, it wasn't removed from the registry immediately 
(it was removed in a callback from OnNativeClose, which happens a bit later.) 
This meant that when the app was loaded again, the window was still in the 
registry with a stale pointer to the old extension. ExtensionSettingsHandler 
was tickling this by iterating shell windows on extension load.

BUG=174250
TEST=On chromeos, enable the 'Enable debugging for packed apps.' flag. Then
open chrome://extensions. Then open a packaged app, and reload it. Chrome
should not crash.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214844

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215745

[benwells, 2013-07-25 08:50:33]

This is https://codereview.chromium.org/12210107/ updated for the current state
of the world.

It originally caused some strange XP bot problem, would like to try relanding as
there was never any good explanation for the XP failure. If it fails again I'll
dig up an off corp machine to test with XP....

[benwells, 2013-07-25 22:59:12]

Forgot to mention,
thakis for c/b/ui/cocoa
estade for c/b/ui/gtk
koz for rest

[Evan Stade, 2013-07-26 16:41:35]

gtk lgtm

[Nico, 2013-07-26 16:48:50]

cocoa lgtm

[koz (OOO until 15th September), 2013-07-29 00:32:37]

https://codereview.chromium.org/20243003/diff/3001/apps/shell_window.cc
File apps/shell_window.cc (right):

https://codereview.chromium.org/20243003/diff/3001/apps/shell_window.cc#newco...
apps/shell_window.cc:294: if (shell_window_contents_ && extension_)
Could you add a comment explaining what |extension_| being NULL here implies and
why that means we don't need to call NativeWindowClosed() below?

[benwells, 2013-07-30 05:25:43]

https://codereview.chromium.org/20243003/diff/3001/apps/shell_window.cc
File apps/shell_window.cc (right):

https://codereview.chromium.org/20243003/diff/3001/apps/shell_window.cc#newco...
apps/shell_window.cc:294: if (shell_window_contents_ && extension_)
On 2013/07/29 00:32:37, koz wrote:
> Could you add a comment explaining what |extension_| being NULL here implies
and
> why that means we don't need to call NativeWindowClosed() below?

Done. I rearranged the code a bit to be a little bit more obvious.

[koz (OOO until 15th September), 2013-07-30 05:35:25]

lgtm

[commit-bot: I haz the power, 2013-07-30 08:03:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/20243003/29001

[commit-bot: I haz the power, 2013-07-30 13:23:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/20243003/29001

[commit-bot: I haz the power, 2013-07-30 23:01:45]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-07-31 07:16:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/20243003/58001

[commit-bot: I haz the power, 2013-07-31 10:20:54]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-07-31 11:52:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/20243003/58001

[commit-bot: I haz the power, 2013-07-31 12:09:59]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-07-31 22:17:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/20243003/58001

[commit-bot: I haz the power, 2013-07-31 22:51:40]

Change committed as 214844

[benwells, 2013-08-01 02:05:47]

On 2013/07/31 22:51:40, I haz the power (commit-bot) wrote:
> Change committed as 214844

A new test got committed while this was in the queue. This change broke the test
and got reverted. Reopening to sort it out.

[commit-bot: I haz the power, 2013-08-05 22:34:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/20243003/94001

[commit-bot: I haz the power, 2013-08-06 00:51:18]

Change committed as 215745