Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1851)

Unified Diff: apps/shell_window.h

Issue 20243003: Fix crash when reloading packaged app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to after mac app shim fix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | apps/shell_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/shell_window.h
diff --git a/apps/shell_window.h b/apps/shell_window.h
index a10cb5bd553337afb52b60d27ab109006401a03d..a1e667bd83e96cca8da384b47a300e281c451a96 100644
--- a/apps/shell_window.h
+++ b/apps/shell_window.h
@@ -181,7 +181,6 @@ class ShellWindow : public content::NotificationObserver,
ShellWindowContents* shell_window_contents,
const CreateParams& params);
-
const std::string& window_key() const { return window_key_; }
const SessionID& session_id() const { return session_id_; }
const extensions::Extension* extension() const { return extension_; }
@@ -299,6 +298,11 @@ class ShellWindow : public content::NotificationObserver,
virtual bool IsWebContentsVisible(
content::WebContents* web_contents) OVERRIDE;
+ // Remove the window from the ShellWindowRegistry and tell the native
+ // window to close. The native window won't be actually closed until
+ // OnNativeClose().
+ void Close();
+
// Helper method to add a message to the renderer's DevTools console.
void AddMessageToDevToolsConsole(content::ConsoleMessageLevel level,
const std::string& message);
« no previous file with comments | « no previous file | apps/shell_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698