Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2016693002: Correctly skip if-null expressions. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + tests/language/regress_26543_1_test.dart View 1 chunk +8 lines, -3 lines 0 comments Download
A tests/language/regress_26543_2_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A tests/language/regress_26543_3_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-26 12:36:00 UTC) #2
Johnni Winther
ping
4 years, 6 months ago (2016-05-27 08:04:23 UTC) #3
eernst
lgtm
4 years, 6 months ago (2016-05-27 08:34:04 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-05-27 08:44:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cd484ddb52b1fa09a15780cce7fecd0839ae5e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698