Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 20157002: Don't let scrollbar thumbs run off their tracks. (Closed)

Created:
7 years, 5 months ago by ccameron
Modified:
7 years, 5 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Don't let scrollbar thumbs run off their tracks. Clamp the value used in calcuating the thumb position to be between 0 and the maximum value (the actual value can be outside this range when over/under scrolling). BUG=133093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M cc/layers/scrollbar_layer_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
This is a prereq for the WebKit patch enabling composited scrollbars on Mac.
7 years, 5 months ago (2013-07-24 22:06:04 UTC) #1
enne (OOO)
lgtm
7 years, 5 months ago (2013-07-24 23:25:44 UTC) #2
ccameron
Thanks!!
7 years, 5 months ago (2013-07-25 00:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/20157002/1
7 years, 5 months ago (2013-07-25 00:38:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/20157002/1
7 years, 5 months ago (2013-07-25 14:52:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/20157002/1
7 years, 5 months ago (2013-07-26 02:40:03 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 13:53:20 UTC) #7
Message was sent while issue was closed.
Change committed as 213896

Powered by Google App Engine
This is Rietveld 408576698