Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5982)

Unified Diff: chrome_frame/test/test_server.cc

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/test_server.h ('k') | content/browser/devtools/devtools_http_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/test_server.cc
diff --git a/chrome_frame/test/test_server.cc b/chrome_frame/test/test_server.cc
index 5162b40e6ee22fb908575a2655900438509a266f..3e918796f416a146cd87a47b9ac4cb934ca6e621 100644
--- a/chrome_frame/test/test_server.cc
+++ b/chrome_frame/test/test_server.cc
@@ -198,9 +198,10 @@ Connection* SimpleWebServer::FindConnection(
return NULL;
}
-void SimpleWebServer::DidAccept(net::StreamListenSocket* server,
- net::StreamListenSocket* connection) {
- connections_.push_back(new Connection(connection));
+void SimpleWebServer::DidAccept(
+ net::StreamListenSocket* server,
+ scoped_ptr<net::StreamListenSocket> connection) {
+ connections_.push_back(new Connection(connection.Pass()));
}
void SimpleWebServer::DidRead(net::StreamListenSocket* connection,
@@ -262,7 +263,6 @@ HTTPTestServer::HTTPTestServer(int port, const std::wstring& address,
}
HTTPTestServer::~HTTPTestServer() {
- server_ = NULL;
}
std::list<scoped_refptr<ConfigurableConnection>>::iterator
@@ -294,8 +294,8 @@ scoped_refptr<ConfigurableConnection> HTTPTestServer::ConnectionFromSocket(
}
void HTTPTestServer::DidAccept(net::StreamListenSocket* server,
- net::StreamListenSocket* socket) {
- connection_list_.push_back(new ConfigurableConnection(socket));
+ scoped_ptr<net::StreamListenSocket> socket) {
+ connection_list_.push_back(new ConfigurableConnection(socket.Pass()));
}
void HTTPTestServer::DidRead(net::StreamListenSocket* socket,
@@ -362,12 +362,12 @@ void ConfigurableConnection::SendChunk() {
FROM_HERE, base::Bind(&ConfigurableConnection::SendChunk, this),
base::TimeDelta::FromMilliseconds(options_.timeout_));
} else {
- socket_ = 0; // close the connection.
+ Close();
}
}
void ConfigurableConnection::Close() {
- socket_ = NULL;
+ socket_.reset();
}
void ConfigurableConnection::Send(const std::string& headers,
« no previous file with comments | « chrome_frame/test/test_server.h ('k') | content/browser/devtools/devtools_http_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698