Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/test_server.cc ('k') | content/browser/devtools/tethering_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index e770b8fe455467545b6046ed6e5455870f9cf1e9..a57c4ccd4cdd9ccab40973a5e06efb9cd90cc526 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -23,7 +23,7 @@ class DummyListenSocket : public StreamListenSocket,
// StreamListenSocket::Delegate "implementation"
virtual void DidAccept(StreamListenSocket* server,
- StreamListenSocket* connection) OVERRIDE {}
+ scoped_ptr<StreamListenSocket> connection) OVERRIDE {}
virtual void DidRead(StreamListenSocket* connection,
const char* data,
int len) OVERRIDE {}
@@ -43,11 +43,11 @@ class DummyListenSocketFactory : public net::StreamListenSocketFactory {
BrowserThread::UI, FROM_HERE, quit_closure_2_);
}
- virtual scoped_refptr<StreamListenSocket> CreateAndListen(
+ virtual scoped_ptr<StreamListenSocket> CreateAndListen(
StreamListenSocket::Delegate* delegate) const OVERRIDE {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE, quit_closure_1_);
- return new DummyListenSocket();
+ return scoped_ptr<net::StreamListenSocket>(new DummyListenSocket());
}
private:
base::Closure quit_closure_1_;
@@ -71,10 +71,10 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate {
virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE {
return std::string();
}
- virtual scoped_refptr<net::StreamListenSocket> CreateSocketForTethering(
+ virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) OVERRIDE {
- return NULL;
+ return scoped_ptr<net::StreamListenSocket>();
}
};
« no previous file with comments | « chrome_frame/test/test_server.cc ('k') | content/browser/devtools/tethering_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698