Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2010763003: Android: Add FramerateRange class (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 6 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Add FramerateRange class The Camera1 and Camera2 API use different framerate range types. Camera1 uses int[2] and Camera2 uses Range<Integer>. Range<Integer> is unfortunately only available on Lollipop and later, so this CL adds a similar FramerateRange class in CaptureFormat. The purpose with this CL is to have a common framerate range type that can be reused from both Camera1 and Camera2 in helper functions such as CameraEnumerationAndroid.getClosestSupportedFramerateRange(). BUG=webrtc:5519 R=sakal@webrtc.org Committed: https://crrev.com/94cb67d6df1a78e7fa25e469f719c1a8809dc583 Cr-Commit-Position: refs/heads/master@{#12942}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Make constant static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -47 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 4 chunks +55 lines, -24 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerator.java View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 2 chunks +15 lines, -10 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
magjed_webrtc
Sami - Please take a look.
4 years, 7 months ago (2016-05-26 12:02:27 UTC) #4
sakal
https://codereview.webrtc.org/2010763003/diff/20001/webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java File webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java (right): https://codereview.webrtc.org/2010763003/diff/20001/webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java#newcode184 webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java:184: public static CaptureFormat.FramerateRange getClosestSupportedFramerateRange( I would move this to ...
4 years, 7 months ago (2016-05-26 12:36:52 UTC) #5
magjed_webrtc
https://codereview.webrtc.org/2010763003/diff/20001/webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java File webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java (right): https://codereview.webrtc.org/2010763003/diff/20001/webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java#newcode184 webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java:184: public static CaptureFormat.FramerateRange getClosestSupportedFramerateRange( On 2016/05/26 12:36:51, sakal wrote: ...
4 years, 7 months ago (2016-05-26 13:13:31 UTC) #7
sakal
On 2016/05/26 13:13:31, magjed_webrtc wrote: > https://codereview.webrtc.org/2010763003/diff/20001/webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java > File webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java (right): > > https://codereview.webrtc.org/2010763003/diff/20001/webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java#newcode184 > ...
4 years, 7 months ago (2016-05-26 13:15:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010763003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010763003/60001
4 years, 7 months ago (2016-05-26 13:50:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-26 15:50:39 UTC) #12
magjed_webrtc
Committed patchset #2 (id:60001) manually as 94cb67d6df1a78e7fa25e469f719c1a8809dc583 (presubmit successful).
4 years, 6 months ago (2016-05-27 08:36:06 UTC) #14
kjellander_webrtc
4 years, 6 months ago (2016-05-30 05:46:13 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.webrtc.org/2024573002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks downstream Android tests:
java.lang.NoSuchFieldError: no field with name='framerate'
signature='org/webrtc/CameraEnumerationAndroid$CaptureFormat$FramerateRange' in
class Lorg/webrtc/CameraEnumerationAndroid$CaptureFormat;

We should have a similar test in WebRTC so we can catch such errors pre-commit..

Powered by Google App Engine
This is Rietveld 408576698