[mips] Initial framework support for MIPS32

[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= https://github.com/dartino/sdk/issues/496
TEST= ninja -C out/DebugXMIPS

Committed: https://github.com/dartino/sdk/commit/39bc68a86d2ab2770bebe579864d5363e889f5cf

[petarj, 2016-05-25 14:49:10]

Description was changed from

==========
[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= Missing support for MIPS32 in Dartino.
==========

to

==========
[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= https://github.com/dartino/sdk/issues/496
==========

[petarj, 2016-05-25 14:49:10]

petarj@mips.com changed reviewers:
+ soren@gjesse.dk

[petarj, 2016-05-25 14:50:03]

petarj@mips.com changed reviewers:
+ sgjesse@google.com
- soren@gjesse.dk

[petarj, 2016-05-25 14:51:02]

Description was changed from

==========
[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= https://github.com/dartino/sdk/issues/496
==========

to

==========
[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= https://github.com/dartino/sdk/issues/496
TEST= ninja -C out/DebugXMIPS
==========

[petarj, 2016-05-25 14:51:40]

First patch uploaded. PTAL.

[Søren Gjesse, 2016-05-26 13:00:19]

Please add yourself to the AUTHORS file as well.

https://codereview.chromium.org/2006403003/diff/20001/default_targets.gypi
File default_targets.gypi (right):

https://codereview.chromium.org/2006403003/diff/20001/default_targets.gypi#ne...
default_targets.gypi:159: 'DebugMIPS': {
Don't you want to add the release targets as well?

https://codereview.chromium.org/2006403003/diff/20001/src/vm/assembler_mips.h
File src/vm/assembler_mips.h (right):

https://codereview.chromium.org/2006403003/diff/20001/src/vm/assembler_mips.h...
src/vm/assembler_mips.h:249: #undef INSTRUCTION_2
undef INSTRUCTION_3 and INSTRUCTION_4 as well?

https://codereview.chromium.org/2006403003/diff/20001/src/vm/interpreter_mips.cc
File src/vm/interpreter_mips.cc (right):

https://codereview.chromium.org/2006403003/diff/20001/src/vm/interpreter_mips...
src/vm/interpreter_mips.cc:349: __ AlignToPowerOfTwo(4);  // align to 8-byte
storage boundary.
Nit: start comment with upper case letter.

https://codereview.chromium.org/2006403003/diff/20001/src/vm/vm.gyp
File src/vm/vm.gyp (right):

https://codereview.chromium.org/2006403003/diff/20001/src/vm/vm.gyp#newcode302
src/vm/vm.gyp:302: 'assembler_mips.h',
Please add these files to rules.mk in the project root for building with the LK
(https://github.com/littlekernel/lk) build system.

[Søren Gjesse, 2016-05-26 13:13:13]

sgjesse@google.com changed reviewers:
+ erikcorry@google.com

[Søren Gjesse, 2016-05-26 13:13:30]

On 2016/05/26 13:00:19, Søren Gjesse wrote:
> Please add yourself to the AUTHORS file as well.
> 
> https://codereview.chromium.org/2006403003/diff/20001/default_targets.gypi
> File default_targets.gypi (right):
> 
>
https://codereview.chromium.org/2006403003/diff/20001/default_targets.gypi#ne...
> default_targets.gypi:159: 'DebugMIPS': {
> Don't you want to add the release targets as well?
> 
> https://codereview.chromium.org/2006403003/diff/20001/src/vm/assembler_mips.h
> File src/vm/assembler_mips.h (right):
> 
>
https://codereview.chromium.org/2006403003/diff/20001/src/vm/assembler_mips.h...
> src/vm/assembler_mips.h:249: #undef INSTRUCTION_2
> undef INSTRUCTION_3 and INSTRUCTION_4 as well?
> 
>
https://codereview.chromium.org/2006403003/diff/20001/src/vm/interpreter_mips.cc
> File src/vm/interpreter_mips.cc (right):
> 
>
https://codereview.chromium.org/2006403003/diff/20001/src/vm/interpreter_mips...
> src/vm/interpreter_mips.cc:349: __ AlignToPowerOfTwo(4);  // align to 8-byte
> storage boundary.
> Nit: start comment with upper case letter.
> 
> https://codereview.chromium.org/2006403003/diff/20001/src/vm/vm.gyp
> File src/vm/vm.gyp (right):
> 
> https://codereview.chromium.org/2006403003/diff/20001/src/vm/vm.gyp#newcode302
> src/vm/vm.gyp:302: 'assembler_mips.h',
> Please add these files to rules.mk in the project root for building with the
LK
> (https://github.com/littlekernel/lk) build system.

Erik Corry will take a look as well.

[erikcorry, 2016-05-26 13:32:51]

Nothing to add to Søren's comments

[petarj, 2016-05-26 14:35:56]

New patch uploaded. PTAL.

https://codereview.chromium.org/2006403003/diff/20001/default_targets.gypi
File default_targets.gypi (right):

https://codereview.chromium.org/2006403003/diff/20001/default_targets.gypi#ne...
default_targets.gypi:159: 'DebugMIPS': {
On 2016/05/26 13:00:19, Søren Gjesse wrote:
> Don't you want to add the release targets as well?

Done. (It was meant to be in one of the later patches).

https://codereview.chromium.org/2006403003/diff/20001/src/vm/assembler_mips.h
File src/vm/assembler_mips.h (right):

https://codereview.chromium.org/2006403003/diff/20001/src/vm/assembler_mips.h...
src/vm/assembler_mips.h:249: #undef INSTRUCTION_2
On 2016/05/26 13:00:19, Søren Gjesse wrote:
> undef INSTRUCTION_3 and INSTRUCTION_4 as well?

Done.

https://codereview.chromium.org/2006403003/diff/20001/src/vm/interpreter_mips.cc
File src/vm/interpreter_mips.cc (right):

https://codereview.chromium.org/2006403003/diff/20001/src/vm/interpreter_mips...
src/vm/interpreter_mips.cc:349: __ AlignToPowerOfTwo(4);  // align to 8-byte
storage boundary.
On 2016/05/26 13:00:19, Søren Gjesse wrote:
> Nit: start comment with upper case letter.

Done.

https://codereview.chromium.org/2006403003/diff/20001/src/vm/vm.gyp
File src/vm/vm.gyp (right):

https://codereview.chromium.org/2006403003/diff/20001/src/vm/vm.gyp#newcode302
src/vm/vm.gyp:302: 'assembler_mips.h',
On 2016/05/26 13:00:19, Søren Gjesse wrote:
> Please add these files to rules.mk in the project root for building with the
LK
> (https://github.com/littlekernel/lk) build system.

Done.

[Søren Gjesse, 2016-05-30 13:08:35]

Description was changed from

==========
[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= https://github.com/dartino/sdk/issues/496
TEST= ninja -C out/DebugXMIPS
==========

to

==========
[mips] Initial framework support for MIPS32

Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= https://github.com/dartino/sdk/issues/496
TEST= ninja -C out/DebugXMIPS

Committed:
https://github.com/dartino/sdk/commit/39bc68a86d2ab2770bebe579864d5363e889f5cf
==========

[Søren Gjesse, 2016-05-30 13:08:36]

Committed patchset #3 (id:40001) manually as
39bc68a86d2ab2770bebe579864d5363e889f5cf (presubmit successful).

[Søren Gjesse, 2016-05-30 13:09:35]

On 2016/05/30 13:08:36, Søren Gjesse wrote:
> Committed patchset #3 (id:40001) manually as
> 39bc68a86d2ab2770bebe579864d5363e889f5cf (presubmit successful).

Patch landed, thanks!