Chromium Code Reviews| Index: chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc |
| diff --git a/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc b/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc |
| index 5599335821f22eda382268ef5d3cb2fd39a01a51..7252fea07b076311a497e158e10f49f80020535a 100644 |
| --- a/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc |
| +++ b/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc |
| @@ -121,6 +121,11 @@ TEST_F(PasswordDialogControllerTest, ShowAccountChooser) { |
| histogram_tester.ExpectUniqueSample( |
| "PasswordManager.AccountChooserDialog", |
| password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN, 1); |
| + histogram_tester.ExpectUniqueSample( |
| + "PasswordManager.AccountChooserDialogMultipleAccounts", |
| + password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN, 1); |
| + histogram_tester.ExpectTotalCount( |
| + "PasswordManager.AccountChooserDialogOneAccount", 0); |
| } |
| TEST_F(PasswordDialogControllerTest, ShowAccountChooserAndSignIn) { |
| @@ -147,14 +152,21 @@ TEST_F(PasswordDialogControllerTest, ShowAccountChooserAndSignIn) { |
| histogram_tester.ExpectUniqueSample( |
| "PasswordManager.AccountChooserDialog", |
| password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN, 1); |
| + histogram_tester.ExpectUniqueSample( |
| + "PasswordManager.AccountChooserDialogOneAccount", |
| + password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN, 1); |
| + histogram_tester.ExpectTotalCount( |
| + "PasswordManager.AccountChooserDialogMultipleAccounts", 0); |
| } |
| TEST_F(PasswordDialogControllerTest, AccountChooserClosed) { |
| base::HistogramTester histogram_tester; |
| StrictMock<MockPasswordPrompt> prompt; |
| + std::vector<std::unique_ptr<autofill::PasswordForm>> locals; |
| + locals.push_back( |
| + base::WrapUnique(new autofill::PasswordForm(GetLocalForm()))); |
| EXPECT_CALL(prompt, ShowAccountChooser()); |
| - controller().ShowAccountChooser(&prompt, |
| - PasswordDialogController::FormsVector(), |
| + controller().ShowAccountChooser(&prompt, std::move(locals), |
|
Ilya Sherman
2016/05/20 21:59:23
Hmm, why did you need to make this change?
vasilii-Google
2016/05/23 11:03:46
I want the account chooser to have 1 account. 0 ac
|
| PasswordDialogController::FormsVector()); |
| EXPECT_CALL(ui_controller_mock(), OnDialogHidden()); |
| @@ -162,6 +174,11 @@ TEST_F(PasswordDialogControllerTest, AccountChooserClosed) { |
| histogram_tester.ExpectUniqueSample( |
| "PasswordManager.AccountChooserDialog", |
| password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED, 1); |
| + histogram_tester.ExpectUniqueSample( |
| + "PasswordManager.AccountChooserDialogOneAccount", |
| + password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED, 1); |
| + histogram_tester.ExpectTotalCount( |
| + "PasswordManager.AccountChooserDialogMultipleAccounts", 0); |
| } |
| TEST_F(PasswordDialogControllerTest, AutoSigninPromo) { |