components/password_manager/core/browser/password_manager_metrics_util.h - Issue 2002643002: Add separate UMA histograms for the account chooser with 1/many accounts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2002643002: Add separate UMA histograms for the account chooser with 1/many accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc ('K') | « chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc ('k') | components/password_manager/core/browser/password_manager_metrics_util.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index e6c8839cb9bc21b17cf703d717bef3afc4f201a9..0cbe9f4d3b9c885868b0e2a9e41dda0755954cb0 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -173,7 +173,8 @@ void LogMultiAccountUpdateBubbleUserAction(

void LogAutoSigninPromoUserAction(AutoSigninPromoUserAction action);

// Log a user action on showing the account chooser.

-void LogAccountChooserUserAction(AccountChooserUserAction action);

+void LogAccountChooserUserAction(AccountChooserUserAction action,

+ bool one_account);

Ilya Sherman 2016/05/20 21:59:23 nit: Please define a pair of enumerated constants

vasilii-Google 2016/05/23 11:03:46 Done.

} // namespace metrics_util