Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/ui/passwords/password_dialog_controller_impl.cc

Issue 2002643002: Add separate UMA histograms for the account chooser with 1/many accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/password_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/passwords/password_dialog_controller_impl.cc b/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
index 6eb80c570bee2a571ff8645ded44a46faa44e2d0..4f5084479f86c7089f534ec66bd40cf99972841d 100644
--- a/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
+++ b/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
@@ -113,7 +113,8 @@ void PasswordDialogControllerImpl::OnChooseCredentials(
const autofill::PasswordForm& password_form,
password_manager::CredentialType credential_type) {
password_manager::metrics_util::LogAccountChooserUserAction(
- password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN);
+ password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN,
+ local_credentials_.size() == 1);
ResetDialog();
delegate_->ChooseCredential(password_form, credential_type);
}
@@ -121,7 +122,7 @@ void PasswordDialogControllerImpl::OnChooseCredentials(
void PasswordDialogControllerImpl::OnSignInClicked() {
DCHECK_EQ(1u, local_credentials_.size());
password_manager::metrics_util::LogAccountChooserUserAction(
- password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN);
+ password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN, true);
ResetDialog();
delegate_->ChooseCredential(
*local_credentials_[0],
@@ -151,7 +152,8 @@ void PasswordDialogControllerImpl::OnAutoSigninTurnOff() {
void PasswordDialogControllerImpl::OnCloseDialog() {
if (account_chooser_dialog_) {
password_manager::metrics_util::LogAccountChooserUserAction(
- password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED);
+ password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED,
+ local_credentials_.size() == 1);
account_chooser_dialog_ = nullptr;
}
if (autosignin_dialog_) {

Powered by Google App Engine
This is Rietveld 408576698