Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/ui/passwords/password_dialog_controller_impl.cc

Issue 2002643002: Add separate UMA histograms for the account chooser with 1/many accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/password_dialog_controller_impl.h" 5 #include "chrome/browser/ui/passwords/password_dialog_controller_impl.h"
6 6
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/browser/sync/profile_sync_service_factory.h" 8 #include "chrome/browser/sync/profile_sync_service_factory.h"
9 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h" 9 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
10 #include "chrome/browser/ui/passwords/password_dialog_prompts.h" 10 #include "chrome/browser/ui/passwords/password_dialog_prompts.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 } 106 }
107 107
108 void PasswordDialogControllerImpl::OnSmartLockLinkClicked() { 108 void PasswordDialogControllerImpl::OnSmartLockLinkClicked() {
109 delegate_->NavigateToSmartLockHelpPage(); 109 delegate_->NavigateToSmartLockHelpPage();
110 } 110 }
111 111
112 void PasswordDialogControllerImpl::OnChooseCredentials( 112 void PasswordDialogControllerImpl::OnChooseCredentials(
113 const autofill::PasswordForm& password_form, 113 const autofill::PasswordForm& password_form,
114 password_manager::CredentialType credential_type) { 114 password_manager::CredentialType credential_type) {
115 password_manager::metrics_util::LogAccountChooserUserAction( 115 password_manager::metrics_util::LogAccountChooserUserAction(
116 password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN); 116 password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN,
117 local_credentials_.size() == 1);
117 ResetDialog(); 118 ResetDialog();
118 delegate_->ChooseCredential(password_form, credential_type); 119 delegate_->ChooseCredential(password_form, credential_type);
119 } 120 }
120 121
121 void PasswordDialogControllerImpl::OnSignInClicked() { 122 void PasswordDialogControllerImpl::OnSignInClicked() {
122 DCHECK_EQ(1u, local_credentials_.size()); 123 DCHECK_EQ(1u, local_credentials_.size());
123 password_manager::metrics_util::LogAccountChooserUserAction( 124 password_manager::metrics_util::LogAccountChooserUserAction(
124 password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN); 125 password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN, true);
125 ResetDialog(); 126 ResetDialog();
126 delegate_->ChooseCredential( 127 delegate_->ChooseCredential(
127 *local_credentials_[0], 128 *local_credentials_[0],
128 password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD); 129 password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD);
129 } 130 }
130 131
131 void PasswordDialogControllerImpl::OnAutoSigninOK() { 132 void PasswordDialogControllerImpl::OnAutoSigninOK() {
132 password_bubble_experiment::RecordAutoSignInPromptFirstRunExperienceWasShown( 133 password_bubble_experiment::RecordAutoSignInPromptFirstRunExperienceWasShown(
133 profile_->GetPrefs()); 134 profile_->GetPrefs());
134 password_manager::metrics_util::LogAutoSigninPromoUserAction( 135 password_manager::metrics_util::LogAutoSigninPromoUserAction(
135 password_manager::metrics_util::AUTO_SIGNIN_OK_GOT_IT); 136 password_manager::metrics_util::AUTO_SIGNIN_OK_GOT_IT);
136 ResetDialog(); 137 ResetDialog();
137 OnCloseDialog(); 138 OnCloseDialog();
138 } 139 }
139 140
140 void PasswordDialogControllerImpl::OnAutoSigninTurnOff() { 141 void PasswordDialogControllerImpl::OnAutoSigninTurnOff() {
141 profile_->GetPrefs()->SetBoolean( 142 profile_->GetPrefs()->SetBoolean(
142 password_manager::prefs::kCredentialsEnableAutosignin, false); 143 password_manager::prefs::kCredentialsEnableAutosignin, false);
143 password_bubble_experiment::RecordAutoSignInPromptFirstRunExperienceWasShown( 144 password_bubble_experiment::RecordAutoSignInPromptFirstRunExperienceWasShown(
144 profile_->GetPrefs()); 145 profile_->GetPrefs());
145 password_manager::metrics_util::LogAutoSigninPromoUserAction( 146 password_manager::metrics_util::LogAutoSigninPromoUserAction(
146 password_manager::metrics_util::AUTO_SIGNIN_TURN_OFF); 147 password_manager::metrics_util::AUTO_SIGNIN_TURN_OFF);
147 ResetDialog(); 148 ResetDialog();
148 OnCloseDialog(); 149 OnCloseDialog();
149 } 150 }
150 151
151 void PasswordDialogControllerImpl::OnCloseDialog() { 152 void PasswordDialogControllerImpl::OnCloseDialog() {
152 if (account_chooser_dialog_) { 153 if (account_chooser_dialog_) {
153 password_manager::metrics_util::LogAccountChooserUserAction( 154 password_manager::metrics_util::LogAccountChooserUserAction(
154 password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED); 155 password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED,
156 local_credentials_.size() == 1);
155 account_chooser_dialog_ = nullptr; 157 account_chooser_dialog_ = nullptr;
156 } 158 }
157 if (autosignin_dialog_) { 159 if (autosignin_dialog_) {
158 password_manager::metrics_util::LogAutoSigninPromoUserAction( 160 password_manager::metrics_util::LogAutoSigninPromoUserAction(
159 password_manager::metrics_util::AUTO_SIGNIN_NO_ACTION); 161 password_manager::metrics_util::AUTO_SIGNIN_NO_ACTION);
160 autosignin_dialog_ = nullptr; 162 autosignin_dialog_ = nullptr;
161 } 163 }
162 delegate_->OnDialogHidden(); 164 delegate_->OnDialogHidden();
163 } 165 }
164 166
165 void PasswordDialogControllerImpl::ResetDialog() { 167 void PasswordDialogControllerImpl::ResetDialog() {
166 if (account_chooser_dialog_) { 168 if (account_chooser_dialog_) {
167 account_chooser_dialog_->ControllerGone(); 169 account_chooser_dialog_->ControllerGone();
168 account_chooser_dialog_ = nullptr; 170 account_chooser_dialog_ = nullptr;
169 } 171 }
170 if (autosignin_dialog_) { 172 if (autosignin_dialog_) {
171 autosignin_dialog_->ControllerGone(); 173 autosignin_dialog_->ControllerGone();
172 autosignin_dialog_ = nullptr; 174 autosignin_dialog_ = nullptr;
173 } 175 }
174 } 176 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698