Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 20007002: Move more input-related files to renderer_host/input (Closed)

Created:
7 years, 5 months ago by jdduke (slow)
Modified:
7 years, 5 months ago
Reviewers:
rjkroege, nduca, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, kouhei (in TOK), sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move more input-related files to renderer_host/input Allow more atomic reviews and changes to input-related files in the browser. Classes moved: * TouchEventQueue * GestureEventFilter * TouchpadTapSuppressionController * TouchscreenTapSuppressionController * TapSuppressionControllerClient BUG=245499 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213851

Patch Set 1 #

Patch Set 2 : Fix includes #

Patch Set 3 : Rebase #

Patch Set 4 : Proper gyp exclusions #

Patch Set 5 : Rebase #

Total comments: 2

Patch Set 6 : Proper .gypi alpha ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1659 lines) Patch
D content/browser/renderer_host/gesture_event_filter.h View 1 chunk +0 lines, -208 lines 0 comments Download
D content/browser/renderer_host/gesture_event_filter.cc View 1 chunk +0 lines, -434 lines 0 comments Download
A + content/browser/renderer_host/input/gesture_event_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/gesture_event_filter.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/immediate_input_router.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/immediate_input_router.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/tap_suppression_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/tap_suppression_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/renderer_host/input/tap_suppression_controller_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/touch_event_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/renderer_host/input/touchpad_tap_suppression_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/renderer_host/input/touchpad_tap_suppression_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/touchpad_tap_suppression_controller_aura.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/input/touchscreen_tap_suppression_controller_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
D content/browser/renderer_host/tap_suppression_controller.h View 1 chunk +0 lines, -77 lines 0 comments Download
D content/browser/renderer_host/tap_suppression_controller.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D content/browser/renderer_host/tap_suppression_controller_client.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/renderer_host/touch_event_queue.h View 1 chunk +0 lines, -93 lines 0 comments Download
D content/browser/renderer_host/touch_event_queue.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D content/browser/renderer_host/touchpad_tap_suppression_controller.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/browser/renderer_host/touchpad_tap_suppression_controller.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/renderer_host/touchpad_tap_suppression_controller_aura.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D content/browser/renderer_host/touchscreen_tap_suppression_controller.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/renderer_host/touchscreen_tap_suppression_controller.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D content/browser/renderer_host/touchscreen_tap_suppression_controller_stub.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jdduke (slow)
I believe these are all classes directly referenced by any of the input routers. I'll ...
7 years, 5 months ago (2013-07-22 22:03:05 UTC) #1
nduca
lgtm if it helps :)
7 years, 5 months ago (2013-07-22 22:19:11 UTC) #2
jdduke (slow)
@rjkroege: PTAL. The overall move of input-related files to renderer_host/input will come in fits and ...
7 years, 5 months ago (2013-07-24 14:52:37 UTC) #3
rjkroege
lgtm
7 years, 5 months ago (2013-07-25 00:39:14 UTC) #4
jdduke (slow)
jam@: Could you sign off for content/content_browser.gypi? I'm never sure at what point I should ...
7 years, 5 months ago (2013-07-25 02:03:01 UTC) #5
nduca
Try Piman
7 years, 5 months ago (2013-07-25 15:43:55 UTC) #6
jdduke (slow)
piman@: Just need approval for content/content_browser.gypi. Thanks.
7 years, 5 months ago (2013-07-25 16:15:08 UTC) #7
piman
lgtm https://codereview.chromium.org/20007002/diff/18001/content/content_browser.gypi File content/content_browser.gypi (right): https://codereview.chromium.org/20007002/diff/18001/content/content_browser.gypi#newcode1409 content/content_browser.gypi:1409: 'browser/renderer_host/input/touchscreen_tap_suppression_controller.cc', nit: can you keep these in alpha ...
7 years, 5 months ago (2013-07-25 17:10:37 UTC) #8
jdduke (slow)
https://codereview.chromium.org/20007002/diff/18001/content/content_browser.gypi File content/content_browser.gypi (right): https://codereview.chromium.org/20007002/diff/18001/content/content_browser.gypi#newcode1409 content/content_browser.gypi:1409: 'browser/renderer_host/input/touchscreen_tap_suppression_controller.cc', On 2013/07/25 17:10:38, piman wrote: > nit: can ...
7 years, 5 months ago (2013-07-25 17:48:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/20007002/28001
7 years, 5 months ago (2013-07-25 18:09:18 UTC) #10
jdduke (slow)
+cc: sadrul@. FYI.
7 years, 5 months ago (2013-07-25 22:58:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/20007002/28001
7 years, 5 months ago (2013-07-26 01:43:00 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 11:51:32 UTC) #13
Message was sent while issue was closed.
Change committed as 213851

Powered by Google App Engine
This is Rietveld 408576698