Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19983003: Create ParameterMirror.type lazily. (Closed)

Created:
7 years, 5 months ago by Michael Lippautz (Google)
Modified:
7 years, 5 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Local change to make the type getter lazy. This change adds the last piece missing to inline functionality of CreateMethodMirror and its parameters. (Separate CL.) BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25325

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M runtime/lib/mirrors.cc View 1 2 3 3 chunks +15 lines, -6 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 2 3 2 chunks +17 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Michael Lippautz (Google)
7 years, 5 months ago (2013-07-22 19:46:20 UTC) #1
rmacnak
https://chromiumcodereview.appspot.com/19983003/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://chromiumcodereview.appspot.com/19983003/diff/1/runtime/lib/mirrors_impl.dart#newcode1059 runtime/lib/mirrors_impl.dart:1059: final _reflectee; Add type annotations: final _MirrorReference _reflectee final ...
7 years, 5 months ago (2013-07-22 20:42:32 UTC) #2
Michael Lippautz (Google)
https://chromiumcodereview.appspot.com/19983003/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://chromiumcodereview.appspot.com/19983003/diff/1/runtime/lib/mirrors_impl.dart#newcode1059 runtime/lib/mirrors_impl.dart:1059: final _reflectee; On 2013/07/22 20:42:32, Ryan Macnak wrote: > ...
7 years, 5 months ago (2013-07-22 20:53:34 UTC) #3
siva
https://chromiumcodereview.appspot.com/19983003/diff/5001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/19983003/diff/5001/runtime/lib/mirrors.cc#newcode263 runtime/lib/mirrors.cc:263: CreateMirrorReference(func), Why do we have to create a mirror ...
7 years, 5 months ago (2013-07-22 22:54:31 UTC) #4
Michael Lippautz (Google)
https://chromiumcodereview.appspot.com/19983003/diff/5001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/19983003/diff/5001/runtime/lib/mirrors.cc#newcode263 runtime/lib/mirrors.cc:263: CreateMirrorReference(func), On 2013/07/22 22:54:31, siva wrote: > Why do ...
7 years, 5 months ago (2013-07-22 23:13:37 UTC) #5
siva
lgtm https://chromiumcodereview.appspot.com/19983003/diff/13001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/19983003/diff/13001/runtime/lib/mirrors.cc#newcode266 runtime/lib/mirrors.cc:266: Dart_NewBoolean(i >= fixed_param_count), // optional param? (i >= ...
7 years, 5 months ago (2013-07-23 00:02:29 UTC) #6
Michael Lippautz (Google)
https://chromiumcodereview.appspot.com/19983003/diff/13001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/19983003/diff/13001/runtime/lib/mirrors.cc#newcode266 runtime/lib/mirrors.cc:266: Dart_NewBoolean(i >= fixed_param_count), // optional param? On 2013/07/23 00:02:29, ...
7 years, 5 months ago (2013-07-23 00:39:11 UTC) #7
Michael Lippautz (Google)
7 years, 5 months ago (2013-07-23 00:39:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 manually as r25325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698