Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 19981004: Remove callbacks on USB manipulation methods. (Closed)

Created:
7 years, 5 months ago by Bei Zhang
Modified:
7 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Remove callbacks on USB manipulation methods. They will be restricted to FILE thread. No need for callback. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213314

Patch Set 1 : #

Patch Set 2 : Rebase to master #

Patch Set 3 : Fix browser_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -121 lines) Patch
M chrome/browser/devtools/adb/android_usb_device.cc View 5 chunks +16 lines, -43 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 7 chunks +38 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_apitest.cc View 1 2 7 chunks +15 lines, -27 lines 0 comments Download
M chrome/browser/usb/usb_device_handle.h View 3 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/usb/usb_device_handle.cc View 4 chunks +15 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Bei Zhang
Hi Pavel, Please review. Thanks, Bei
7 years, 5 months ago (2013-07-23 19:46:07 UTC) #1
pfeldman
lgtm
7 years, 5 months ago (2013-07-23 20:17:49 UTC) #2
Bei Zhang
Hi Antony, Please give an owner's review on the following file: chrome/browser/extensions/api/usb/usb_api.cc Thanks, Bei
7 years, 5 months ago (2013-07-23 20:38:25 UTC) #3
asargent_no_longer_on_chrome
When I try to view the diffs I get an error about chunk mismatch and ...
7 years, 5 months ago (2013-07-23 21:43:35 UTC) #4
Bei Zhang
On 2013/07/23 21:43:35, Antony Sargent wrote: > When I try to view the diffs I ...
7 years, 5 months ago (2013-07-23 21:51:23 UTC) #5
asargent_no_longer_on_chrome
lgtm
7 years, 5 months ago (2013-07-23 22:29:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/19981004/50001
7 years, 5 months ago (2013-07-23 22:55:41 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 01:35:46 UTC) #8
Message was sent while issue was closed.
Change committed as 213314

Powered by Google App Engine
This is Rietveld 408576698