Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/devtools/adb/android_usb_device.cc

Issue 19981004: Remove callbacks on USB manipulation methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browser_tests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/usb/usb_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/adb/android_usb_device.cc
diff --git a/chrome/browser/devtools/adb/android_usb_device.cc b/chrome/browser/devtools/adb/android_usb_device.cc
index 4fd1390f6a0d7f4e246d65398030076f3ac9eb3b..94083289d48121c388629435911152cd083d993d 100644
--- a/chrome/browser/devtools/adb/android_usb_device.cc
+++ b/chrome/browser/devtools/adb/android_usb_device.cc
@@ -22,9 +22,6 @@
namespace {
-void Noop() {}
-void BoolNoop(bool success) {}
-
const size_t kHeaderSize = 24;
const int kAdbClass = 0xff;
@@ -93,23 +90,6 @@ static std::string ReadSerialNumSync(libusb_device_handle* handle) {
return std::string();
}
-static void InterfaceClaimed(crypto::RSAPrivateKey* rsa_key,
- scoped_refptr<UsbDeviceHandle> usb_device,
- int inbound_address,
- int outbound_address,
- int zero_mask,
- AndroidUsbDevices* devices,
- bool success) {
- if (!success)
- return;
-
- std::string serial = ReadSerialNumSync(usb_device->handle());
- scoped_refptr<AndroidUsbDevice> device =
- new AndroidUsbDevice(rsa_key, usb_device, serial, inbound_address,
- outbound_address, zero_mask);
- devices->push_back(device);
-}
-
static void ClaimInterface(
crypto::RSAPrivateKey* rsa_key,
scoped_refptr<UsbDeviceHandle> usb_device,
@@ -147,24 +127,14 @@ static void ClaimInterface(
if (inbound_address == 0 || outbound_address == 0)
return;
- usb_device->ClaimInterface(1, base::Bind(&InterfaceClaimed,
- rsa_key, usb_device,
- inbound_address, outbound_address,
- zero_mask, devices));
-}
-
-static void InterfacesListed(
- crypto::RSAPrivateKey* rsa_key,
- scoped_refptr<UsbDeviceHandle> usb_device,
- scoped_refptr<UsbConfigDescriptor> config,
- AndroidUsbDevices* devices,
- bool success) {
- if (!success)
+ if (!usb_device->ClaimInterface(1))
return;
- for (size_t j = 0; j < config->GetNumInterfaces(); ++j) {
- ClaimInterface(rsa_key, usb_device, config->GetInterface(j),
- devices);
- }
+
+ std::string serial = ReadSerialNumSync(usb_device->handle());
+ scoped_refptr<AndroidUsbDevice> device =
+ new AndroidUsbDevice(rsa_key, usb_device, serial, inbound_address,
+ outbound_address, zero_mask);
+ devices->push_back(device);
}
static uint32 Checksum(const std::string& data) {
@@ -257,10 +227,13 @@ void AndroidUsbDevice::Enumerate(Profile* profile,
if (claimed_devices.find(usb_device.get()) != claimed_devices.end())
continue;
scoped_refptr<UsbConfigDescriptor> config = new UsbConfigDescriptor();
- usb_device->ListInterfaces(config.get(),
- base::Bind(&InterfacesListed, rsa_key,
- usb_device, config,
- &g_devices.Get()));
+ bool success = usb_device->ListInterfaces(config.get());
+ if (!success)
+ continue;
+ for (size_t j = 0; j < config->GetNumInterfaces(); ++j) {
+ ClaimInterface(rsa_key, usb_device, config->GetInterface(j),
+ &g_devices.Get());
+ }
}
callback.Run(g_devices.Get());
}
@@ -533,8 +506,8 @@ void AndroidUsbDevice::Terminate() {
it->second->Terminated();
}
- usb_device_->ReleaseInterface(1, base::Bind(&BoolNoop));
- usb_device_->Close(base::Bind(&Noop));
+ usb_device_->ReleaseInterface(1);
+ usb_device_->Close();
}
void AndroidUsbDevice::SocketDeleted(uint32 socket_id) {
« no previous file with comments | « no previous file | chrome/browser/extensions/api/usb/usb_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698