Issue 19976005: [rAc, Mac] Fix a NULL pointer dereference in Mac Autofill dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19976005: [rAc, Mac] Fix a NULL pointer dereference in Mac Autofill dialog. (Closed)

Created:
7 years, 5 months ago by Ilya Sherman

Modified:
7 years, 5 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[rAc, Mac] Fix a NULL pointer dereference in Mac Autofill dialog. The constrained_window_ can already be NULL by the time PerformClose() is called if the dialog is dismissed by clicking either the 'Cancel' or the 'Submit' button. BUG=none TEST=none R=groby@chromium.org

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

LGTM It's fixing the short-term issue, but I think there's a bigger problem - this ...

7 years, 5 months ago (2013-07-24 17:50:25 UTC) #2

Ilya Sherman

7 years, 5 months ago (2013-07-25 04:22:23 UTC) #3

Hmm, I can't repro this crash anymore, so I guess I'll hold off on committing
this CL for now.  If I'm able to repro in the future, I'll try to get callstacks
to understand why we're trying to close the dialog twice...

Expand Messages | Collapse Messages