Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 19976002: Simplify code; no need to pass issue arg to GetApprovingReviewers(). (Closed)

Created:
7 years, 5 months ago by M-A Ruel
Modified:
7 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Simplify code; no need to pass issue arg to GetApprovingReviewers(). The class already knows the issue number. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M git_cl.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
7 years, 5 months ago (2013-07-22 17:47:40 UTC) #1
iannucci
lgtm
7 years, 5 months ago (2013-07-23 01:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/19976002/1
7 years, 5 months ago (2013-07-23 12:57:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 19976002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 5 months ago (2013-07-23 13:00:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/19976002/1
7 years, 5 months ago (2013-07-23 13:06:31 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 13:08:49 UTC) #6
Message was sent while issue was closed.
Change committed as 213083

Powered by Google App Engine
This is Rietveld 408576698