Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: git_cl.py

Issue 19976002: Simplify code; no need to pass issue arg to GetApprovingReviewers(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index bb07ee0815436ffef95ec48850dda43cab848c31..c1ae3f7f1f1dfb16ccd82cb12daada1e1bd3c86b 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -683,9 +683,9 @@ or verify this branch is set up to track another (via the --track argument to
return self.RpcServer().get(
'/download/issue%s_%s.diff' % (issue, patchset))
- def GetApprovingReviewers(self, issue):
+ def GetApprovingReviewers(self):
return get_approving_reviewers(
- self.RpcServer().get_issue_properties(int(issue), True))
+ self.RpcServer().get_issue_properties(self.GetIssue(), True))
def SetIssue(self, issue):
"""Set this branch's issue. If issue=0, clears the issue."""
@@ -1577,7 +1577,7 @@ def SendUpstream(parser, args, cmd):
# the commit viewvc url.
# Keep a separate copy for the commit message.
if cl.GetIssue():
- change_desc.update_reviewers(cl.GetApprovingReviewers(cl.GetIssue()))
+ change_desc.update_reviewers(cl.GetApprovingReviewers())
commit_desc = ChangeDescription(change_desc.description)
if cl.GetIssue():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698