Reimplement device status check dashboard option.

Reimplement device status check dashboard option.

The changes to the device status check step from the following LGTM'd CL was
lost in the move from device_status_check.py to
buildbot/bb_device_status_check.py:
https://chromiumcodereview.appspot.com/19284009/diff/24001/build/android/device_status_check.py

This CL reimplements the option in the new device status check script.

TBR=frankf@chromium.org
BUG=254014
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213194

[commit-bot: I haz the power, 2013-07-22 17:00:26]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[navabi, 2013-07-22 20:51:32]

Ping. I already got an LGTM on this, but the changes were lost in moving
device_status_check.py to bb_device_status_check.py.

The only difference is in android_commands.py where we do not assert that the
device has a wifi ip, because it is not guaranteed the device has an ip.

[Isaac (away), 2013-07-22 22:41:49]

lgtm

[frankf, 2013-07-22 22:43:13]

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:138: return device in
GetAttachedDevices(emulator=True)
Why is this needed?

[navabi, 2013-07-22 23:11:05]

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:138: return device in
GetAttachedDevices(emulator=True)
On 2013/07/22 22:43:13, frankf wrote:
> Why is this needed?

It's called by /src/build/android/pylib/base/test_dispatcher.py

[frankf, 2013-07-22 23:19:44]

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:138: return device in
GetAttachedDevices(emulator=True)
why emulator=True is needed? It's the default.

On 2013/07/22 23:11:05, navabi wrote:
> On 2013/07/22 22:43:13, frankf wrote:
> > Why is this needed?
> 
> It's called by /src/build/android/pylib/base/test_dispatcher.py

[navabi, 2013-07-22 23:44:07]

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/19968004/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:138: return device in
GetAttachedDevices(emulator=True)
On 2013/07/22 23:19:44, frankf wrote:
> why emulator=True is needed? It's the default.
> 
> On 2013/07/22 23:11:05, navabi wrote:
> > On 2013/07/22 22:43:13, frankf wrote:
> > > Why is this needed?
> > 
> > It's called by /src/build/android/pylib/base/test_dispatcher.py
> 

Done.

[commit-bot: I haz the power, 2013-07-23 00:12:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/19968004/10001

[commit-bot: I haz the power, 2013-07-23 01:59:35]

Retried try job too often on linux_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-07-23 06:42:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/19968004/10001

[commit-bot: I haz the power, 2013-07-23 08:37:30]

Retried try job too often on mac_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-07-23 09:22:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/19968004/10001

[commit-bot: I haz the power, 2013-07-23 10:09:23]

Retried try job too often on linux_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-07-23 19:23:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/19968004/10001

[commit-bot: I haz the power, 2013-07-23 19:43:33]

Change committed as 213194