Reimplement device status check dashboard option.

build/android/pylib/android_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to communicate with the device via the adb command.
 
 Assumes adb binary is currently on system path.
 """
 
 import collections
@@ skipping 117 matching lines @@
 
   preferred_device = os.environ.get('ANDROID_SERIAL')
   if preferred_device in devices:
     devices.remove(preferred_device)
     devices.insert(0, preferred_device)
   return devices
 
 
 def IsDeviceAttached(device):
   """Return true if the device is attached and online."""
-  return device in GetAttachedDevices()
+  return device in GetAttachedDevices(emulator=True)

[frankf, 2013/07/22 22:43:13]

Why is this needed?

[navabi, 2013/07/22 23:11:05]

It's called by /src/build/android/pylib/base/test_dispatcher.py

[frankf, 2013/07/22 23:19:44]

why emulator=True is needed? It's the default.

On 2013/07/22 23:11:05, navabi wrote:

[navabi, 2013/07/22 23:44:07]

Done.

 
 
 def _GetFilesFromRecursiveLsOutput(path, ls_output, re_file, utc_offset=None):
   """Gets a list of files from `ls` command output.
 
   Python's os.walk isn't used because it doesn't work over adb shell.
 
   Args:
     path: The path to list.
     ls_output: A list of lines returned by an `ls -lR` command.
@@ skipping 859 matching lines @@
 
   def GetProductModel(self):
     """Returns the name of the product model (e.g. "Galaxy Nexus") """
     model = self.RunShellCommand('getprop ro.product.model')[0]
     assert model
     return model
 
   def GetWifiIP(self):
     """Returns the wifi IP on the device."""
     wifi_ip = self.RunShellCommand('getprop dhcp.wlan0.ipaddress')[0]
-    assert wifi_ip
+    # Do not assert here. Devices (e.g. emulators) may not have a WifiIP.
     return wifi_ip
 
   def GetSubscriberInfo(self):
     """Returns the device subscriber info (e.g. GSM and device ID) as string."""
     iphone_sub = self.RunShellCommand('dumpsys iphonesubinfo')
     assert iphone_sub
     return '\n'.join(iphone_sub)
 
   def GetBatteryInfo(self):
     """Returns the device battery info (e.g. status, level, etc) as string."""
@@ skipping 440 matching lines @@
   """
   def __init__(self, output):
     self._output = output
 
   def write(self, data):
     data = data.replace('\r\r\n', '\n')
     self._output.write(data)
 
   def flush(self):
     self._output.flush()