Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed)

Created:
4 years, 7 months ago by Ian Wen
Modified:
4 years, 7 months ago
Reviewers:
rkaplow, gone
CC:
chromium-reviews, asanka, mcwilliams+watch_chromium.org, romax+watch_chromium.org, tfarina, dewittj+watch_chromium.org, browser-components-watch_chromium.org, petewil+watch_chromium.org, dgn+watch_chromium.org, chili+watch_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, fgorski+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record UMA for snackbars shown for all purposes Having some UMA about how often we show a specific type of snackbars is valuable torwards our UX decision making. BUG=606045 Committed: https://crrev.com/983aefc15d85474ea7cc19461666cdfe8de997b8 Cr-Commit-Position: refs/heads/master@{#394028}

Patch Set 1 #

Total comments: 4

Patch Set 2 : make identifier a parameter in constructor #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -44 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUndoController.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java View 1 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java View 1 4 chunks +30 lines, -3 lines 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/snackbar/SnackbarCollectionUnitTest.java View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ian Wen
PTAL
4 years, 7 months ago (2016-05-16 20:49:35 UTC) #2
rkaplow
lgtm not an expert on the android side but overall lg https://codereview.chromium.org/1982803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java File chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java (right): ...
4 years, 7 months ago (2016-05-16 21:52:09 UTC) #3
gone
https://codereview.chromium.org/1982803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java File chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java (right): https://codereview.chromium.org/1982803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java#newcode77 chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java:77: public static Snackbar make(CharSequence text, SnackbarController controller, int type) ...
4 years, 7 months ago (2016-05-16 22:43:55 UTC) #4
Ian Wen
All addressed. https://chromiumcodereview.appspot.com/1982803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java File chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java (right): https://chromiumcodereview.appspot.com/1982803002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java#newcode38 chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java:38: public static final int UMA_INVALID = -1; ...
4 years, 7 months ago (2016-05-17 01:07:55 UTC) #5
gone
lgtm https://codereview.chromium.org/1982803002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java File chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java (right): https://codereview.chromium.org/1982803002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java#newcode75 chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java:75: * @param identifier The feature code of the ...
4 years, 7 months ago (2016-05-17 01:11:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982803002/20001
4 years, 7 months ago (2016-05-17 01:14:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 02:41:32 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 02:43:18 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/983aefc15d85474ea7cc19461666cdfe8de997b8
Cr-Commit-Position: refs/heads/master@{#394028}

Powered by Google App Engine
This is Rietveld 408576698