Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
index e676700312eedc3b0a00b7a15d3fdf98b381d1c9..2b721e6e4f170e1c60c81e5c4510af6992a76a8c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
@@ -55,7 +55,7 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr
if (getSnackbarManager() == null) return;
Snackbar snackbar = Snackbar.make(
mContext.getString(R.string.download_succeeded_message, downloadInfo.getFileName()),
- this, Snackbar.TYPE_NOTIFICATION);
+ this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DOWNLOAD_SUCCEEDED);
// TODO(qinmin): Coalesce snackbars if multiple downloads finish at the same time.
snackbar.setDuration(SNACKBAR_DURATION_IN_MILLISECONDS).setSingleLine(false);
Pair<DownloadInfo, Long> actionData = null;
@@ -71,13 +71,15 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr
/**
* Called to display the download failed snackbar.
*
- * @param filename File name of the failed download.
- * @param whether to show all downloads in case the failure is caused by duplicated files.
+ * @param errorMessage The message to show on the snackbar.
+ * @param showAllDownloads Whether to show all downloads in case the failure is caused by
+ * duplicated files.
*/
public void onDownloadFailed(String errorMessage, boolean showAllDownloads) {
if (getSnackbarManager() == null) return;
// TODO(qinmin): Coalesce snackbars if multiple downloads finish at the same time.
- Snackbar snackbar = Snackbar.make(errorMessage, this, Snackbar.TYPE_NOTIFICATION)
+ Snackbar snackbar = Snackbar
+ .make(errorMessage, this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DOWNLOAD_FAILED)
.setSingleLine(false)
.setDuration(SNACKBAR_DURATION_IN_MILLISECONDS);
if (showAllDownloads) {

Powered by Google App Engine
This is Rietveld 408576698