Issue 19804008: Add a Blink API to set window features on a WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19804008: Add a Blink API to set window features on a WebView. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add a Blink API to set window features on a WebView. This will allow for re-creating a popup with correct window features after we've decided to block the popup and not create it previously. With the old popup blocking behavior, the new WebView was just hidden, and we never had to set the features manually. BUG=38458 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154883

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -37 lines)			Patch
M	Source/core/page/Chrome.h	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	Source/core/page/Chrome.cpp	View	3 chunks	+7 lines, -22 lines	0 comments	Download
M	Source/core/page/CreateWindow.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/web/WebViewImpl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	public/web/WebView.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	public/web/WebWindowFeatures.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19804008/1

7 years, 5 months ago (2013-07-24 22:35:33 UTC) #3

Message was sent while issue was closed.

Change committed as 154883

Expand Messages | Collapse Messages