Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Unified Diff: sync/protocol/synced_notification_render.proto

Issue 19771013: Adapting the UI to bring it closer to the spec, and fixing image fetching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adapting the UI: fix unit tests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/synced_notification_render.proto
diff --git a/sync/protocol/synced_notification_render.proto b/sync/protocol/synced_notification_render.proto
index 46d890f491c2411c1132a0fb3f2d5331fcb0dae4..5ee073ed4f1c173d3d28d4f800a713da8e009be1 100644
--- a/sync/protocol/synced_notification_render.proto
+++ b/sync/protocol/synced_notification_render.proto
@@ -36,6 +36,11 @@ message CollapsedInfo {
optional SyncedNotificationDestination default_destination = 3;
repeated Target target = 4;
+
+ // Defines a repeated list of meta tags that provide some context on what
+ // this collapsed info is describing. Nothing about the display of this
+ // collapsed info is defined by the meta tags.
+ repeated string meta_tag = 5;
}
// Render information for the expanded (detail) view of a coalesced
@@ -45,6 +50,13 @@ message ExpandedInfo {
// Collapsed information for each notification in the coalesced group.
repeated CollapsedInfo collapsed_info = 2;
+
+ // A set of targets for actions the user can take, or destinations the
+ // viewer can be taken to. These relate to the coalesced notification.
+ repeated Target target = 3;
+
+ // Enhanced context for the expanded view.
+ repeated string meta_tag = 4;
}
message SimpleCollapsedLayout {
@@ -60,6 +72,13 @@ message SimpleCollapsedLayout {
// Description - often the action that generated the notification.
optional string description = 4;
+
+ // Media - one or more shared media items.
+ repeated Media media = 5;
+
+ // Annotation - often the annotation of the entity generating the
+ // notification.
+ optional string annotation = 6;
}
message SimpleExpandedLayout {
@@ -134,6 +153,10 @@ message SyncedNotificationAction {
// Optional label to aid accessibility.
optional string accessibility_label= 5;
+
+ // Defines a repeated list of meta tags that provide some context on this
+ // action. Nothing about the display of this action is defined by the tags.
+ repeated string meta_tag = 6;
}
message SyncedNotificationImage {
« no previous file with comments | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698