Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: sync/protocol/synced_notification_render.proto

Issue 19771013: Adapting the UI to bring it closer to the spec, and fixing image fetching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adapting the UI: fix unit tests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 5
6 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 6 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
7 // any fields in this file. 7 // any fields in this file.
8 8
9 syntax = "proto2"; 9 syntax = "proto2";
10 10
(...skipping 18 matching lines...) Expand all
29 optional SimpleCollapsedLayout simple_collapsed_layout = 1; 29 optional SimpleCollapsedLayout simple_collapsed_layout = 1;
30 30
31 // The creation time of the notification in microseconds since the UNIX 31 // The creation time of the notification in microseconds since the UNIX
32 // epoch. 32 // epoch.
33 optional uint64 creation_timestamp_usec = 2; 33 optional uint64 creation_timestamp_usec = 2;
34 34
35 // The default destination target. 35 // The default destination target.
36 optional SyncedNotificationDestination default_destination = 3; 36 optional SyncedNotificationDestination default_destination = 3;
37 37
38 repeated Target target = 4; 38 repeated Target target = 4;
39
40 // Defines a repeated list of meta tags that provide some context on what
41 // this collapsed info is describing. Nothing about the display of this
42 // collapsed info is defined by the meta tags.
43 repeated string meta_tag = 5;
39 } 44 }
40 45
41 // Render information for the expanded (detail) view of a coalesced 46 // Render information for the expanded (detail) view of a coalesced
42 // notification. 47 // notification.
43 message ExpandedInfo { 48 message ExpandedInfo {
44 optional SimpleExpandedLayout simple_expanded_layout = 1; 49 optional SimpleExpandedLayout simple_expanded_layout = 1;
45 50
46 // Collapsed information for each notification in the coalesced group. 51 // Collapsed information for each notification in the coalesced group.
47 repeated CollapsedInfo collapsed_info = 2; 52 repeated CollapsedInfo collapsed_info = 2;
53
54 // A set of targets for actions the user can take, or destinations the
55 // viewer can be taken to. These relate to the coalesced notification.
56 repeated Target target = 3;
57
58 // Enhanced context for the expanded view.
59 repeated string meta_tag = 4;
48 } 60 }
49 61
50 message SimpleCollapsedLayout { 62 message SimpleCollapsedLayout {
51 // Application icon. 63 // Application icon.
52 optional SyncedNotificationImage app_icon = 1; 64 optional SyncedNotificationImage app_icon = 1;
53 65
54 // Profile image(s) of the notification creator(s) to show in the 66 // Profile image(s) of the notification creator(s) to show in the
55 // collapsed UI. 67 // collapsed UI.
56 repeated SyncedNotificationProfileImage profile_image = 2; 68 repeated SyncedNotificationProfileImage profile_image = 2;
57 69
58 // Heading - often the name(s) of the notification creator(s). 70 // Heading - often the name(s) of the notification creator(s).
59 optional string heading = 3; 71 optional string heading = 3;
60 72
61 // Description - often the action that generated the notification. 73 // Description - often the action that generated the notification.
62 optional string description = 4; 74 optional string description = 4;
75
76 // Media - one or more shared media items.
77 repeated Media media = 5;
78
79 // Annotation - often the annotation of the entity generating the
80 // notification.
81 optional string annotation = 6;
63 } 82 }
64 83
65 message SimpleExpandedLayout { 84 message SimpleExpandedLayout {
66 // Title - often the title of the underlying entity referred to by the 85 // Title - often the title of the underlying entity referred to by the
67 // notification(s). 86 // notification(s).
68 optional string title = 1; 87 optional string title = 1;
69 88
70 // Text content - often a snippet of text from the underlying entity 89 // Text content - often a snippet of text from the underlying entity
71 // reference or the notification. 90 // reference or the notification.
72 optional string text = 2; 91 optional string text = 2;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 optional SyncedNotificationImage icon = 2; 146 optional SyncedNotificationImage icon = 2;
128 147
129 // The URL that performs the action. 148 // The URL that performs the action.
130 optional string url = 3; 149 optional string url = 3;
131 150
132 // Additional request data. 151 // Additional request data.
133 optional string request_data = 4; 152 optional string request_data = 4;
134 153
135 // Optional label to aid accessibility. 154 // Optional label to aid accessibility.
136 optional string accessibility_label= 5; 155 optional string accessibility_label= 5;
156
157 // Defines a repeated list of meta tags that provide some context on this
158 // action. Nothing about the display of this action is defined by the tags.
159 repeated string meta_tag = 6;
137 } 160 }
138 161
139 message SyncedNotificationImage { 162 message SyncedNotificationImage {
140 // Note that the image may be from any source. Clients wishing to resize the 163 // Note that the image may be from any source. Clients wishing to resize the
141 // image should ensure the image is proxied appropriately. 164 // image should ensure the image is proxied appropriately.
142 optional string url = 1; 165 optional string url = 1;
143 optional string alt_text = 2; 166 optional string alt_text = 2;
144 optional int32 preferred_width = 3; 167 optional int32 preferred_width = 3;
145 optional int32 preferred_height = 4; 168 optional int32 preferred_height = 4;
146 } 169 }
147 170
148 message SyncedNotificationProfileImage { 171 message SyncedNotificationProfileImage {
149 // Url for the image. 172 // Url for the image.
150 optional string image_url = 1; 173 optional string image_url = 1;
151 // Object id for the image. 174 // Object id for the image.
152 optional string oid = 2; 175 optional string oid = 2;
153 // Name to display for this image. 176 // Name to display for this image.
154 optional string display_name = 3; 177 optional string display_name = 3;
155 } 178 }
OLDNEW
« no previous file with comments | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698