Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 19768007: Don't post accessibility notification on object in detached document. (Closed)

Created:
7 years, 5 months ago by dmazzoni
Modified:
7 years, 5 months ago
Reviewers:
inferno
CC:
blink-reviews, dglazkov+blink, dmazzoni, eae+blinkwatch, aboxhall
Visibility:
Public.

Description

Don't post accessibility notification on object in detached document. This can happen if an accessibility notification is queued on a node, then that node is reparented to a different document that's not attached anywhere before the accessibility notification is fired. BUG=257348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmazzoni
I can only get a layout test to reproduce this crash if you start content ...
7 years, 5 months ago (2013-07-18 21:13:27 UTC) #1
inferno
lgtm, it is ok to skip test in this case since it does not reproduce ...
7 years, 5 months ago (2013-07-18 21:21:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/19768007/1
7 years, 5 months ago (2013-07-18 21:29:05 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-19 00:00:33 UTC) #4
Message was sent while issue was closed.
Change committed as 154542

Powered by Google App Engine
This is Rietveld 408576698