Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: Source/core/accessibility/AXObjectCache.cpp

Issue 19768007: Don't post accessibility notification on object in detached document. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 RefPtr<Document> protectorForCacheOwner(m_document); 615 RefPtr<Document> protectorForCacheOwner(m_document);
616 616
617 m_notificationPostTimer.stop(); 617 m_notificationPostTimer.stop();
618 618
619 unsigned i = 0, count = m_notificationsToPost.size(); 619 unsigned i = 0, count = m_notificationsToPost.size();
620 for (i = 0; i < count; ++i) { 620 for (i = 0; i < count; ++i) {
621 AccessibilityObject* obj = m_notificationsToPost[i].first.get(); 621 AccessibilityObject* obj = m_notificationsToPost[i].first.get();
622 if (!obj->axObjectID()) 622 if (!obj->axObjectID())
623 continue; 623 continue;
624 624
625 if (!obj->axObjectCache())
626 continue;
627
625 #ifndef NDEBUG 628 #ifndef NDEBUG
626 // Make sure none of the render views are in the process of being layed out. 629 // Make sure none of the render views are in the process of being layed out.
627 // Notifications should only be sent after the renderer has finished 630 // Notifications should only be sent after the renderer has finished
628 if (obj->isAccessibilityRenderObject()) { 631 if (obj->isAccessibilityRenderObject()) {
629 AccessibilityRenderObject* renderObj = static_cast<AccessibilityRend erObject*>(obj); 632 AccessibilityRenderObject* renderObj = static_cast<AccessibilityRend erObject*>(obj);
630 RenderObject* renderer = renderObj->renderer(); 633 RenderObject* renderer = renderObj->renderer();
631 if (renderer && renderer->view()) 634 if (renderer && renderer->view())
632 ASSERT(!renderer->view()->layoutState()); 635 ASSERT(!renderer->view()->layoutState());
633 } 636 }
634 #endif 637 #endif
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 void AXObjectCache::handleScrolledToAnchor(const Node* anchorNode) 1022 void AXObjectCache::handleScrolledToAnchor(const Node* anchorNode)
1020 { 1023 {
1021 // The anchor node may not be accessible. Post the notification for the 1024 // The anchor node may not be accessible. Post the notification for the
1022 // first accessible object. 1025 // first accessible object.
1023 postPlatformNotification(AccessibilityObject::firstAccessibleObjectFromNode( anchorNode), AXScrolledToAnchor); 1026 postPlatformNotification(AccessibilityObject::firstAccessibleObjectFromNode( anchorNode), AXScrolledToAnchor);
1024 } 1027 }
1025 1028
1026 } // namespace WebCore 1029 } // namespace WebCore
1027 1030
1028 #endif // HAVE(ACCESSIBILITY) 1031 #endif // HAVE(ACCESSIBILITY)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698