Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 19756002: Undo band-aid which was ignoring wrong SessionStorage association. (Closed)

Created:
7 years, 5 months ago by marja
Modified:
7 years, 5 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Undo band-aid which was ignoring wrong SessionStorage association. The band-aid was r143761. Now that crbug.com/138152 is fixed, we can hopefully do without. Note: It is possible that this commit causes renderer crashes, if we still didn't get the SessionStorage association right. Please see crbug.com/134003. BUG=134003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M webkit/browser/dom_storage/dom_storage_host.cc View 3 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
marja
michaeln, ptal at this trivial change
7 years, 5 months ago (2013-07-18 08:52:48 UTC) #1
michaeln
lgtm, thank you so much for following up on this! Can you run some tryjobs? ...
7 years, 5 months ago (2013-07-18 22:24:23 UTC) #2
marja
Oh noes, the WebViewTest.DOMStorageIsolation fails without the bandaid, but works if I revert the actual ...
7 years, 5 months ago (2013-07-19 15:17:11 UTC) #3
marja
A better fix ( https://chromiumcodereview.appspot.com/19491004 ) is now in, let's try the bandaid removal again...
7 years, 5 months ago (2013-07-24 06:55:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/19756002/1
7 years, 5 months ago (2013-07-24 06:56:41 UTC) #5
commit-bot: I haz the power
Change committed as 213384
7 years, 5 months ago (2013-07-24 10:13:31 UTC) #6
michaeln
7 years, 5 months ago (2013-07-24 23:10:24 UTC) #7
Message was sent while issue was closed.
wooohooo :)

Powered by Google App Engine
This is Rietveld 408576698