Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 19491004: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed)

Created:
7 years, 5 months ago by marja
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, michaeln
Visibility:
Public.

Description

Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. Both RenderViewHostImpl and NavigationController had SessionStorageNamespace*, and under some circumstances, they pointed to different SessionStorageNamespaces* which is wrong. This change makes it so that only NavigationController knows about SessionStorageNamespace. For more information, see bug. BUG=138152 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/test_render_view_host_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_render_view_host_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
marja
jochen, ajwong, ptal. This is like https://codereview.chromium.org/18500005 (that one got reverted) except better. The beef ...
7 years, 5 months ago (2013-07-23 13:59:02 UTC) #1
marja
(cc michaeln again)
7 years, 5 months ago (2013-07-23 13:59:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-23 14:02:31 UTC) #3
marja
oops, not awong but ajwong. ptal, ajwong.
7 years, 5 months ago (2013-07-23 19:54:27 UTC) #4
awong
LGTM (fyi, ajwong and awong both work I think)
7 years, 5 months ago (2013-07-23 19:59:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/19491004/1
7 years, 5 months ago (2013-07-23 20:17:08 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 23:02:44 UTC) #7
Message was sent while issue was closed.
Change committed as 213253

Powered by Google App Engine
This is Rietveld 408576698