Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 19749008: Fix regression in TypedefMirror.owner introduced when making ClassMirror.owner lazy. (Closed)

Created:
7 years, 5 months ago by rmacnak
Modified:
7 years, 5 months ago
Reviewers:
ahe, siva, Ivan Posva
CC:
reviews_dartlang.org, dgrove, Michael Lippautz (Google)
Visibility:
Public.

Description

Fix regression in TypedefMirror.owner introduced when making ClassMirror.owner lazy. Committed: https://code.google.com/p/dart/source/detail?r=25244

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/mirrors/mirrors_test.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rmacnak
7 years, 5 months ago (2013-07-19 20:16:38 UTC) #1
siva
https://codereview.chromium.org/19749008/diff/3001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/19749008/diff/3001/runtime/lib/mirrors_impl.dart#newcode730 runtime/lib/mirrors_impl.dart:730: } Why not put this code in 'get owner' ...
7 years, 5 months ago (2013-07-19 21:06:07 UTC) #2
rmacnak
https://codereview.chromium.org/19749008/diff/3001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/19749008/diff/3001/runtime/lib/mirrors_impl.dart#newcode730 runtime/lib/mirrors_impl.dart:730: } On 2013/07/19 21:06:07, siva wrote: > Why not ...
7 years, 5 months ago (2013-07-19 21:11:39 UTC) #3
siva
lgtm
7 years, 5 months ago (2013-07-19 21:14:35 UTC) #4
ahe
lgtm
7 years, 5 months ago (2013-07-20 16:36:18 UTC) #5
rmacnak
This was commited as r25244, but gclient crashed in the middle and failed to mark ...
7 years, 5 months ago (2013-07-22 18:25:40 UTC) #6
ahe
7 years, 5 months ago (2013-07-22 18:30:54 UTC) #7
Message was sent while issue was closed.
On 2013/07/22 18:25:40, Ryan Macnak wrote:
> This was commited as r25244, but gclient crashed in the middle and failed to
> mark this as closed.

You can manually close the issue under "edit issue", also you can update the
description to include a link to the commit using another CL as template.

Powered by Google App Engine
This is Rietveld 408576698