Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 19744006: Ensure model is passed with <template if> (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M pkg/mdv/lib/src/template_iterator.dart View 1 1 chunk +14 lines, -3 lines 0 comments Download
M pkg/mdv/test/template_element_test.dart View 1 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
7 years, 5 months ago (2013-07-23 20:36:02 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/19744006/diff/1/pkg/mdv/lib/src/template_iterator.dart File pkg/mdv/lib/src/template_iterator.dart (right): https://codereview.chromium.org/19744006/diff/1/pkg/mdv/lib/src/template_iterator.dart#newcode53 pkg/mdv/lib/src/template_iterator.dart:53: !attrs.containsKey('repeat')) { might be worth adding a small ...
7 years, 5 months ago (2013-07-23 20:44:13 UTC) #2
Jennifer Messerly
https://chromiumcodereview.appspot.com/19744006/diff/1/pkg/mdv/lib/src/template_iterator.dart File pkg/mdv/lib/src/template_iterator.dart (right): https://chromiumcodereview.appspot.com/19744006/diff/1/pkg/mdv/lib/src/template_iterator.dart#newcode53 pkg/mdv/lib/src/template_iterator.dart:53: !attrs.containsKey('repeat')) { On 2013/07/23 20:44:14, Siggi Cherem (dart-lang) wrote: ...
7 years, 5 months ago (2013-07-23 22:11:59 UTC) #3
Jennifer Messerly
7 years, 5 months ago (2013-07-23 22:12:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698