Issue 19714004: Revert 213148 "Add asserts to TestingProfile::CreateHistoryServi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19714004: Revert 213148 "Add asserts to TestingProfile::CreateHistoryServi..." (Closed)

Created:
7 years, 5 months ago by rlarocque

Modified:
7 years, 5 months ago

Reviewers:
rmcilroy

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 213148 "Add asserts to TestingProfile::CreateHistoryServi..." Failed on the build bot: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/48941 > Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/19616004 TBR=rmcilroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213151

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -71 lines)			Patch
M	trunk/src/chrome/browser/autocomplete/extension_app_provider_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc	View	4 chunks	+5 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/bookmarks/bookmark_index_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/browsing_data/browsing_data_remover_unittest.cc	View	6 chunks	+8 lines, -16 lines	0 comments	Download
M	trunk/src/chrome/browser/download/download_target_determiner_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/history/android/android_history_provider_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/history/android/sqlite_cursor_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/history/history_backend_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/history/in_memory_url_index_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/history/top_sites_impl_unittest.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/history/top_sites_likely_impl_unittest.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/importer/profile_writer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/profiles/profile_manager_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/safe_browsing/malware_details_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/search_engines/template_url_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/test/base/testing_profile.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/test/base/testing_profile.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/test/perf/generate_profile.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r213151.

Expand Messages | Collapse Messages