Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/test/perf/generate_profile.cc

Issue 19714004: Revert 213148 "Add asserts to TestingProfile::CreateHistoryServi..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/test/base/testing_profile.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/test/perf/generate_profile.cc
===================================================================
--- trunk/src/chrome/test/perf/generate_profile.cc (revision 213150)
+++ trunk/src/chrome/test/perf/generate_profile.cc (working copy)
@@ -229,10 +229,7 @@
content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
content::TestBrowserThread db_thread(BrowserThread::DB, &message_loop);
TestingProfile profile;
- if (!profile.CreateHistoryService(false, false)) {
- PLOG(ERROR) << "Creating history service failed";
- return false;
- }
+ profile.CreateHistoryService(false, false);
if (types & TOP_SITES) {
profile.CreateTopSites();
profile.BlockUntilTopSitesLoaded();
« no previous file with comments | « trunk/src/chrome/test/base/testing_profile.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698