Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970363002: Add timeline events for compiling static initializers and writing full snapshots. Remove timeline e… (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add timeline events for compiling static initializers and writing full snapshots. Remove timeline event for InitCompiler. Fail gracefully for missing flags when writing full snapshots. Also fix PRODUCT build. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/37d08d6ebc51e5537ddc3d14ade7797cd8fbcae8

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -33 lines) Patch
M runtime/vm/compiler.cc View 1 1 chunk +25 lines, -13 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 10 chunks +19 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/snapshot.cc View 6 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
4 years, 7 months ago (2016-05-13 18:11:25 UTC) #2
Cutch
LGTM with a small suggestion. Also, maybe double check that you hit all VMTagScopes. https://chromiumcodereview.appspot.com/1970363002/diff/1/runtime/vm/compiler.cc ...
4 years, 7 months ago (2016-05-13 20:23:27 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1970363002/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/1970363002/diff/1/runtime/vm/compiler.cc#newcode1573 runtime/vm/compiler.cc:1573: #ifndef PRODUCT On 2016/05/13 20:23:27, Cutch wrote: > could ...
4 years, 7 months ago (2016-05-16 16:28:50 UTC) #5
rmacnak
4 years, 7 months ago (2016-05-16 16:28:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
37d08d6ebc51e5537ddc3d14ade7797cd8fbcae8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698