courgette/disassembler_elf_32_x86.cc - Issue 1969543002: Unified usage of vector<unique_ptr<T>>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_x86.cc

Issue 1969543002: Unified usage of vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32_x86.cc

diff --git a/courgette/disassembler_elf_32_x86.cc b/courgette/disassembler_elf_32_x86.cc

index f73371c2cef276ecc0cc8f8b04314c58f526f5d3..4eb2df7d4e4f9501cbab674ee672d8df100c61f9 100644

--- a/courgette/disassembler_elf_32_x86.cc

+++ b/courgette/disassembler_elf_32_x86.cc

@@ -185,7 +185,7 @@ CheckBool DisassemblerElf32X86::ParseRel32RelocsFromSection(

RVA target_rva = typed_rel32_rva->rva() +

typed_rel32_rva->relative_target();

if (IsValidTargetRVA(target_rva)) {

- rel32_locations_.push_back(typed_rel32_rva.release());

+ rel32_locations_.push_back(std::move(typed_rel32_rva));

#if COURGETTE_HISTOGRAM_TARGETS

++rel32_target_rvas_[target_rva];

#endif