Unified usage of vector<unique_ptr<T>>

courgette/disassembler_elf_32_x86.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler_elf_32_x86.h"
 
 #include <memory>
 #include <vector>

[huangs, 2016/05/11 04:49:23]

#include <utility>

for std::move().

[etiennep, 2016/05/11 18:19:13]

Done.

 
 #include "base/logging.h"
 #include "courgette/assembly_program.h"
 #include "courgette/courgette.h"
 
 namespace courgette {
 
 CheckBool DisassemblerElf32X86::TypedRVAX86::ComputeRelativeTarget(
     const uint8_t* op_pointer) {
   set_relative_target(Read32LittleEndian(op_pointer) + 4);
@@ skipping 159 matching lines @@
         }
       }
 
       std::unique_ptr<TypedRVAX86> typed_rel32_rva(new TypedRVAX86(rel32_rva));
       if (!typed_rel32_rva->ComputeRelativeTarget(rel32))
         return false;
 
       RVA target_rva = typed_rel32_rva->rva() +
           typed_rel32_rva->relative_target();
       if (IsValidTargetRVA(target_rva)) {
-        rel32_locations_.push_back(typed_rel32_rva.release());
+        rel32_locations_.push_back(std::move(typed_rel32_rva));
 #if COURGETTE_HISTOGRAM_TARGETS
         ++rel32_target_rvas_[target_rva];
 #endif
         p = rel32 + 4;
         continue;
       }
     }
     p += 1;
   }
 
   return true;
 }
 
 }  // namespace courgette