Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: courgette/disassembler_elf_32_x86_unittest.cc

Issue 1969543002: Unified usage of vector<unique_ptr<T>> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "courgette/disassembler_elf_32_x86.h" 5 #include "courgette/disassembler_elf_32_x86.h"
6 6
7 #include <ctype.h> 7 #include <ctype.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 std::unique_ptr<AssemblyProgram> program(new AssemblyProgram(EXE_ELF_32_X86)); 92 std::unique_ptr<AssemblyProgram> program(new AssemblyProgram(EXE_ELF_32_X86));
93 93
94 EXPECT_TRUE(disassembler->Disassemble(program.get())); 94 EXPECT_TRUE(disassembler->Disassemble(program.get()));
95 95
96 const std::vector<RVA>& abs32_list = disassembler->Abs32Locations(); 96 const std::vector<RVA>& abs32_list = disassembler->Abs32Locations();
97 97
98 // Flatten the list typed rel32 to a list of rel32 RVAs. 98 // Flatten the list typed rel32 to a list of rel32 RVAs.
99 std::vector<RVA> rel32_list; 99 std::vector<RVA> rel32_list;
100 rel32_list.reserve(disassembler->Rel32Locations().size()); 100 rel32_list.reserve(disassembler->Rel32Locations().size());
101 for (TypedRVA* typed_rel32 : disassembler->Rel32Locations()) 101 for (auto& typed_rel32 : disassembler->Rel32Locations())
102 rel32_list.push_back(typed_rel32->rva()); 102 rel32_list.push_back(typed_rel32->rva());
103 103
104 EXPECT_EQ(expected_abs_count, abs32_list.size()); 104 EXPECT_EQ(expected_abs_count, abs32_list.size());
105 EXPECT_EQ(expected_rel_count, rel32_list.size()); 105 EXPECT_EQ(expected_rel_count, rel32_list.size());
106 106
107 EXPECT_TRUE(std::is_sorted(abs32_list.begin(), abs32_list.end())); 107 EXPECT_TRUE(std::is_sorted(abs32_list.begin(), abs32_list.end()));
108 EXPECT_TRUE(std::is_sorted(rel32_list.begin(), rel32_list.end())); 108 EXPECT_TRUE(std::is_sorted(rel32_list.begin(), rel32_list.end()));
109 109
110 // Verify that rel32 RVAs do not overlap with abs32 RVAs. 110 // Verify that rel32 RVAs do not overlap with abs32 RVAs.
111 // TODO(huangs): Fix this to account for RVA's 4-byte width. 111 // TODO(huangs): Fix this to account for RVA's 4-byte width.
(...skipping 17 matching lines...) Expand all
129 } 129 }
130 130
131 } // namespace 131 } // namespace
132 132
133 TEST_F(DisassemblerElf32X86Test, All) { 133 TEST_F(DisassemblerElf32X86Test, All) {
134 TestExe("elf-32-1", 200, 3337); 134 TestExe("elf-32-1", 200, 3337);
135 TestExe("elf-32-high-bss", 0, 4); 135 TestExe("elf-32-high-bss", 0, 4);
136 } 136 }
137 137
138 } // namespace courgette 138 } // namespace courgette
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698