Issue 19674007: Revert 212129 "Cleaning up TODO(joi) entries in //net."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19674007: Revert 212129 "Cleaning up TODO(joi) entries in //net." (Closed)

Created:
7 years, 5 months ago by michaeln

Modified:
7 years, 5 months ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 212129 "Cleaning up TODO(joi) entries in //net." > Cleaning up TODO(joi) entries in //net. > > The two TODOs related to threading are apparently gone so I'm removing > the TODOs and associated code. > > I no longer think it's worth pursuing the idea of separating > throttling and the sliding window concept, so transforming a TODO > related to that to just an observation. > > TBR=darin@chromium.org > BUG=none > > Review URL: https://chromiumcodereview.appspot.com/18261003 TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212148

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -6 lines)			Patch
M	trunk/src/chrome/browser/io_thread.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/net/base/backoff_entry.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/net/url_request/url_request_throttler_manager.h	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	trunk/src/net/url_request/url_request_throttler_manager.cc	View	4 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

michaeln

Sorry to have reverted, but was seeing thread check failures... http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/39542/steps/browser_tests/logs/stdio

7 years, 5 months ago (2013-07-17 22:33:59 UTC) #3

Jói

7 years, 5 months ago (2013-07-17 23:11:09 UTC) #4

LGTM, thanks for the revert.

On Wed, Jul 17, 2013 at 10:33 PM,  <michaeln@chromium.org> wrote:
> Sorry to have reverted, but was seeing thread check failures...
>
>
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg...
>
> https://chromiumcodereview.appspot.com/19674007/

Expand Messages | Collapse Messages