Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 18261003: Cleaning up TODO(joi) entries in //net. (Closed)

Created:
7 years, 5 months ago by Jói
Modified:
7 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Cleaning up TODO(joi) entries in //net. The two TODOs related to threading are apparently gone so I'm removing the TODOs and associated code. I no longer think it's worth pursuing the idea of separating throttling and the sliding window concept, so transforming a TODO related to that to just an observation. TBR=darin@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212129

Patch Set 1 #

Patch Set 2 : Merge LKGR. #

Patch Set 3 : Merge LKGR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -33 lines) Patch
M chrome/browser/io_thread.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/backoff_entry.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_throttler_manager.h View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 4 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jói
7 years, 5 months ago (2013-07-08 16:48:42 UTC) #1
eroman
lgtm
7 years, 5 months ago (2013-07-09 02:03:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/18261003/1
7 years, 5 months ago (2013-07-10 15:03:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=14515
7 years, 5 months ago (2013-07-10 15:12:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/18261003/30001
7 years, 5 months ago (2013-07-16 15:01:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=60272
7 years, 5 months ago (2013-07-16 16:17:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/18261003/30001
7 years, 5 months ago (2013-07-17 14:37:11 UTC) #7
commit-bot: I haz the power
Change committed as 212129
7 years, 5 months ago (2013-07-17 21:19:41 UTC) #8
michaeln
sorry... see https://chromiumcodereview.appspot.com/19674007/
7 years, 5 months ago (2013-07-17 22:34:38 UTC) #9
Jói
7 years, 5 months ago (2013-07-17 23:11:03 UTC) #10
Thanks for the revert.  If there were thread check failures on the
waterfall after this, it's quite likely this was the culprit.  Too bad
it got past the trybots.

Cheers,
Jói


2013/7/17  <michaeln@chromium.org>:
> sorry... see https://chromiumcodereview.appspot.com/19674007/
>
> https://chromiumcodereview.appspot.com/18261003/

Powered by Google App Engine
This is Rietveld 408576698