Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 19668006: [CSS Grid Layout] infinity should be defined as a negative value (Closed)

Created:
7 years, 5 months ago by Julien - ping for review
Modified:
7 years, 5 months ago
Reviewers:
ojan
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, esprehn, eseidel
Visibility:
Public.

Description

[CSS Grid Layout] infinity should be defined as a negative value This change makes us reject negative lengths at parse time, which matches the updated specification, so that we can now safely assume that when we resolve the length, it is not to a negative value. BUG=234209 TESTS=fast/css-grid-layout/grid-columns-rows-get-set.html fast/css-grid-layout/grid-columns-rows-get-set-multiple.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Simple parsing change for grid that cleans up some code!
7 years, 5 months ago (2013-07-23 20:29:56 UTC) #1
ojan
lgtm
7 years, 5 months ago (2013-07-24 01:05:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/19668006/1
7 years, 5 months ago (2013-07-24 01:05:34 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 03:52:33 UTC) #4
Message was sent while issue was closed.
Change committed as 154805

Powered by Google App Engine
This is Rietveld 408576698