LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 19668006: [CSS Grid Layout] infinity should be defined as a negative value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 19668006: [CSS Grid Layout] infinity should be defined as a negative value (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index 0f9ff1129f2736e5fdfb91e908519ec413b1c923..40471898fde37e804180b1f88c61cda90edca765 100755

--- a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -241,6 +241,17 @@ element.style.gridDefinitionRows = "-8,0fr";

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'none'");

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'none'");

+// Negative values are not allowed.

+element.style.gridDefinitionColumns = "-1px";

+element.style.gridDefinitionRows = "-6em";

+shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'none'");

+shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'none'");

+element.style.gridDefinitionColumns = "minmax(-1%, 32%)";

+element.style.gridDefinitionRows = "minmax(2vw, -6em)";

+shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'none'");

+shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'none'");

debug("");

debug("Test setting grid-definition-columns and grid-definition-rows back to 'none' through JS");

element.style.gridDefinitionColumns = "18px";