Plumb in flag for reusing scratch textures

Plumb in flag for reusing scratch textures

Committed: http://code.google.com/p/skia/source/detail?r=10170

[robertphillips, 2013-07-17 16:51:32]

https://codereview.chromium.org/19636002/diff/1/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/19636002/diff/1/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:49: */
An option would be to pass in a tri-value enum (e.g., reuse, don't, default).

https://codereview.chromium.org/19636002/diff/1/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:91: */
This would remain a bool

https://codereview.chromium.org/19636002/diff/1/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:878: 
This would remain a bool

https://codereview.chromium.org/19636002/diff/1/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:888: GrContext(); // init must be called after the
constructor.
This would also become tri-value

[bsalomon, 2013-07-18 18:12:08]

https://codereview.chromium.org/19636002/diff/4001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/19636002/diff/4001/include/gpu/GrContext.h#ne...
include/gpu/GrContext.h:87: * Change the context's scratch texture reuse
behavior. On some platforms
Do we need this function at all? Do we need anything external to GrContext to
control this?

https://codereview.chromium.org/19636002/diff/4001/include/gpu/GrContext.h#ne...
include/gpu/GrContext.h:878: bool                           
fReuseScratchTextures;
Do we need this or can it just look at the GrGpu's caps?

[bsalomon, 2013-07-18 18:21:40]

https://codereview.chromium.org/19636002/diff/4001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/19636002/diff/4001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:953: 
Need to init here.

https://codereview.chromium.org/19636002/diff/4001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:969: fPathStencilingSupport =
other.fPathStencilingSupport;
Need to assign here.

[robertphillips, 2013-07-18 19:06:39]

PTAL

https://codereview.chromium.org/19636002/diff/4001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/19636002/diff/4001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:953: 
On 2013/07/18 18:21:40, bsalomon wrote:
> Need to init here.

Done.

https://codereview.chromium.org/19636002/diff/4001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:969: fPathStencilingSupport =
other.fPathStencilingSupport;
On 2013/07/18 18:21:40, bsalomon wrote:
> Need to assign here.

Done.

[brian1, 2013-07-18 20:10:51]

lgtm

[commit-bot: I haz the power, 2013-07-18 22:19:05]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/robertphillips@google.com/19636002/11001

[commit-bot: I haz the power, 2013-07-18 22:26:41]

Change committed as 10170