Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 19614004: Compositor hit test performance improvement (Closed)

Created:
7 years, 5 months ago by Rick Byers
Modified:
7 years, 4 months ago
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Visibility:
Public.

Description

Compositor hit test performance improvement When computing touch hit rects, keep track of the rect for the parent element in the render tree. If a child lives in the same layer and it's rect is entirely contained by the parent (fairly common in practice), then we can skip it. For the sites I've found with the most hit rects (from our main telemetry page sets), this decreases hit rect computation time by about 20-60%. BUG=263416 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155344

Patch Set 1 #

Patch Set 2 : Add missing updated test expectations #

Patch Set 3 : Merge with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -57 lines) Patch
M LayoutTests/fast/events/touch/compositor-touch-hit-rects-expected.txt View 1 3 chunks +6 lines, -10 lines 0 comments Download
M LayoutTests/fast/events/touch/compositor-touch-hit-rects-scroll-expected.txt View 1 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/events/touch/compositor-touch-hit-rects-expected.txt View 1 3 chunks +6 lines, -10 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 2 chunks +23 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Rick Byers
Levi, This is the first, in what I hope is a series of perf optimizations ...
7 years, 5 months ago (2013-07-23 17:20:50 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 5 months ago (2013-07-23 20:54:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/19614004/1
7 years, 5 months ago (2013-07-23 20:55:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18137
7 years, 5 months ago (2013-07-23 22:00:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/19614004/15001
7 years, 5 months ago (2013-07-24 03:08:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14412
7 years, 5 months ago (2013-07-24 05:26:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/19614004/15001
7 years, 5 months ago (2013-07-24 15:33:42 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14537
7 years, 5 months ago (2013-07-24 17:24:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/19614004/15001
7 years, 5 months ago (2013-07-24 18:11:47 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14561
7 years, 5 months ago (2013-07-24 20:10:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/19614004/35001
7 years, 4 months ago (2013-08-01 14:37:48 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 16:57:56 UTC) #12
Message was sent while issue was closed.
Change committed as 155344

Powered by Google App Engine
This is Rietveld 408576698