chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java - Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

index 0cc2bfcca8caaba17940aa73b9ab39d6842d4bd0..66f47e34cc3d94f3072e321ba40e986cb35eb3e3 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

@@ -12,6 +12,7 @@ import android.content.Intent;

import android.content.SharedPreferences;

import org.chromium.base.test.util.Feature;

+import org.chromium.blink_public.platform.WebDisplayMode;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.testing.local.BackgroundShadowAsyncTask;

import org.chromium.testing.local.LocalRobolectricTestRunner;

@@ -603,6 +604,6 @@ public class WebappRegistryTest {

private Intent createShortcutIntent(String url) {

return ShortcutHelper.createWebappShortcutIntent("id", "action", url,

ShortcutHelper.getScopeFromUrl(url), "name", "shortName", null,

- ShortcutHelper.WEBAPP_SHORTCUT_VERSION, 0, 0, 0, false);

+ ShortcutHelper.WEBAPP_SHORTCUT_VERSION, WebDisplayMode.Standalone, 0, 0, 0, false);

}