chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java - Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

index 92e6bf64422c4dd5d4f5eae29f6360bf84cea420..419c49bba7fecda29046cad3ab4f2ba7988226d5 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

@@ -13,6 +13,7 @@ import android.content.SharedPreferences;

import android.graphics.Bitmap;

import org.chromium.base.test.util.Feature;

+import org.chromium.blink_public.platform.WebDisplayMode;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.testing.local.BackgroundShadowAsyncTask;

import org.chromium.testing.local.LocalRobolectricTestRunner;

@@ -245,13 +246,14 @@ public class WebappDataStorageTest {

final String name = "name";

final String shortName = "shortName";

final Bitmap icon = createBitmap();

+ final int displayMode = WebDisplayMode.Standalone;

final int orientation = 1;

final long themeColor = 2;

final long backgroundColor = 3;

final boolean isIconGenerated = false;

Intent shortcutIntent = ShortcutHelper.createWebappShortcutIntent(id, action, url, scope,

- name, shortName, icon, ShortcutHelper.WEBAPP_SHORTCUT_VERSION, orientation,

- themeColor, backgroundColor, isIconGenerated);

+ name, shortName, icon, ShortcutHelper.WEBAPP_SHORTCUT_VERSION, displayMode,

+ orientation, themeColor, backgroundColor, isIconGenerated);

WebappDataStorage storage = WebappDataStorage.open(Robolectric.application, "test");

storage.updateFromShortcutIntent(shortcutIntent);