Issue 19597007: telemetry: Fixed summary of by_url results when page-repeat>1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19597007: telemetry: Fixed summary of by_url results when page-repeat>1 (Closed)

Created:
7 years, 5 months ago by ernstm

Modified:
7 years, 5 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

telemetry: Fixed summary of by_url results when page-repeat>1 - Code for making URL list was only working for pageset-repeat, but not for page-repeat (breaking out of the loop when the first cycle is found) - Fixed by using a Set in addition to the List to efficiently make URLs unique while preserving order - Added unittest for page-repeat>1 R=tonyg@chromium.org BUG=263600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213348

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -2 lines)			Patch
	M	tools/telemetry/telemetry/page/buildbot_page_measurement_results.py	View		1 chunk	+6 lines, -2 lines	0 comments	Download
	M	tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/19597007/1

7 years, 5 months ago (2013-07-23 23:04:02 UTC) #3

Message was sent while issue was closed.

Change committed as 213348

Expand Messages | Collapse Messages