Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tools/telemetry/telemetry/page/buildbot_page_measurement_results.py

Issue 19597007: telemetry: Fixed summary of by_url results when page-repeat>1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/buildbot_page_measurement_results.py
diff --git a/tools/telemetry/telemetry/page/buildbot_page_measurement_results.py b/tools/telemetry/telemetry/page/buildbot_page_measurement_results.py
index c086eff4a142444cfcf74f93fbe7760fd907a173..0f1ab814546bc3a91e51c7d18c37c98040943cd4 100644
--- a/tools/telemetry/telemetry/page/buildbot_page_measurement_results.py
+++ b/tools/telemetry/telemetry/page/buildbot_page_measurement_results.py
@@ -33,12 +33,16 @@ class BuildbotPageMeasurementResults(
success_page_results = self._page_results
# Print out the list of unique pages.
+ # Use a set and a list to efficiently create an order preserving list of
+ # unique URLs.
unique_page_urls = []
+ unique_page_urls_set = set()
for page_values in success_page_results:
url = page_values.page.display_url
- if unique_page_urls and unique_page_urls[0] == url:
- break
+ if url in unique_page_urls_set:
+ continue
unique_page_urls.append(url)
+ unique_page_urls_set.add(url)
perf_tests_helper.PrintPages(unique_page_urls)
# Build the results summary.
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698